I checked this and the icons are in the right order: moon is low brightness, sun is high brightness. The slider is a threshold, so moving it to the right means the app requires a brighter screen before switching to light mode. If your current brightness is below that threshold, it switches to dark. That makes sense to me.